PR #23484 opened by Zhao Zhili (quink)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23484
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23484.patch

Signed-off-by: Zhao Zhili <[email protected]>

# Summary of changes

The loop incremented `height_tags` twice per element, once in the `for` header 
and once in the loop body.

<!--
If this PR requires new FATE test samples, attach them to the PR and
list their target paths below (relative to the fate-suite root).

Attached filenames must match the sample's filename:

```fate-samples
# e.g. vorbis/new-sample.ogg
```
-->



>From 16597818946c944c44a6166b7e3807a477794abd Mon Sep 17 00:00:00 2001
From: Zhao Zhili <[email protected]>
Date: Mon, 15 Jun 2026 16:59:32 +0800
Subject: [PATCH] avcodec/aacdec: fix double-increment of height_tags in loop

Signed-off-by: Zhao Zhili <[email protected]>
---
 libavcodec/aac/aacdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c
index 52e3e73ed0..202c7aa30c 100644
--- a/libavcodec/aac/aacdec.c
+++ b/libavcodec/aac/aacdec.c
@@ -948,7 +948,7 @@ static int decode_pce(AVCodecContext *avctx, 
MPEG4AudioConfig *m4ac,
                         memcpy(layout_map + height_tags, 
&tag[AAC_CHANNEL_LFE][j], sizeof(*layout_map));
                         height_tags++;
                     }
-                    for (int j = 0; j < num_cc; j++, height_tags++) {
+                    for (int j = 0; j < num_cc; j++) {
                         memcpy(layout_map + height_tags, 
&tag[AAC_CHANNEL_CC][j], sizeof(*layout_map));
                         height_tags++;
                     }
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to