PR #23509 opened by Hunter Kvalevog (kvog) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23509 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23509.patch
Hi. This is related in spirit to #21177. Currently, `--enable-libtheora` does not find libtheora on macOS when theora is installed via Homebrew. Detection via pkg-config is done in addition to the existing method, as recommended in the linked PR. theoraenc.pc will link `-ltheoraenc`, `-ltheoradec`, and `-logg`, and has [for a long time](https://gitlab.xiph.org/xiph/theora/-/commits/main/theoraenc.pc.in). >From 39635fcc3b5f601f93ffaf72cba730facc875100 Mon Sep 17 00:00:00 2001 From: Hunter Kvalevog <[email protected]> Date: Mon, 15 Jun 2026 13:56:07 -0500 Subject: [PATCH] configure: add pkg-config check for libtheora This allows libtheora to be found via pkg-config in addition to the existing approach. Signed-off-by: Hunter Kvalevog <[email protected]> --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index e67aa362ad..ceb11ac8d0 100755 --- a/configure +++ b/configure @@ -7472,7 +7472,8 @@ enabled libsvtav1 && require_pkg_config libsvtav1 "SvtAv1Enc >= 0.9.0" E enabled libsvtjpegxs && require_pkg_config libsvtjpegxs "SvtJpegxs >= 0.10.0" SvtJpegxsEnc.h svt_jpeg_xs_encoder_init enabled libtensorflow && require libtensorflow tensorflow/c/c_api.h TF_Version -ltensorflow enabled libtesseract && require_pkg_config libtesseract tesseract tesseract/capi.h TessBaseAPICreate -enabled libtheora && require libtheora theora/theoraenc.h th_info_init -ltheoraenc -ltheoradec -logg +enabled libtheora && { check_pkg_config libtheora theoraenc theora/theoraenc.h th_info_init || + require libtheora theora/theoraenc.h th_info_init -ltheoraenc -ltheoradec -logg; } enabled libtls && require_pkg_config libtls libtls tls.h tls_configure && { enabled gpl && ! enabled nonfree && die "ERROR: LibreSSL is incompatible with the gpl"; } enabled libtorch && check_cxxflags -std=c++17 && require_cxx libtorch torch/torch.h "torch::Tensor" -ltorch -lc10 -ltorch_cpu -lstdc++ -lpthread -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
