PR #23960 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23960 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23960.patch
armasm64 warns "A4228: Alignment value exceeds AREA alignment; alignment not guaranteed" on the .Lcoeffs literal pool. gas-preprocessor.pl emits the text section as "AREA |.text|, CODE, READONLY, ALIGN=4", i.e. a 16-byte section alignment, so a 32-byte ALIGN inside it cannot be guaranteed by the assembler. 16 is enough here: the pool holds .quad values that are read with "ldr d0, .Lcoeffs" literal loads, which only require 8-byte alignment. It also matches the rest of the aarch64 asm, where the function and const macros both default to .align 4. From aa19597a1b82637cf0263c153acce7c6a63b12be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= <[email protected]> Date: Thu, 30 Jul 2026 14:00:33 +0200 Subject: [PATCH] avcodec/aarch64/vc1dsp_neon: reduce literal pool alignment to 16 bytes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit armasm64 warns "A4228: Alignment value exceeds AREA alignment; alignment not guaranteed" on the .Lcoeffs literal pool. gas-preprocessor.pl emits the text section as "AREA |.text|, CODE, READONLY, ALIGN=4", i.e. a 16-byte section alignment, so a 32-byte ALIGN inside it cannot be guaranteed by the assembler. 16 is enough here: the pool holds .quad values that are read with "ldr d0, .Lcoeffs" literal loads, which only require 8-byte alignment. It also matches the rest of the aarch64 asm, where the function and const macros both default to .align 4. Signed-off-by: Kacper Michajłow <[email protected]> --- libavcodec/aarch64/vc1dsp_neon.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aarch64/vc1dsp_neon.S b/libavcodec/aarch64/vc1dsp_neon.S index 9a96c2523c..d8e7788026 100644 --- a/libavcodec/aarch64/vc1dsp_neon.S +++ b/libavcodec/aarch64/vc1dsp_neon.S @@ -696,7 +696,7 @@ function ff_vc1_inv_trans_4x4_dc_neon, export=1 ret endfunc -.align 5 +.align 4 .Lcoeffs_it8: .quad 0x000F00090003 .Lcoeffs_it4: -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
