PR #25108 opened by romainhedouin
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/25108
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/25108.patch

The check compared the width twice so a height-only change was not rejected 
when debayering.

Found during a code review sweep of ffmpeg using an LLM.

Signed-off-by: romainhedouin <[email protected]>

<!--
If this PR requires new FATE test samples, attach them to the PR and
list their target paths below (relative to the fate-suite root).

Attached filenames must match the sample's filename:

```fate-samples
# e.g. vorbis/new-sample.ogg
```
-->



>From ef1ffdba0705473680485d6b48de0ddde646ba3f Mon Sep 17 00:00:00 2001
From: romainhedouin <[email protected]>
Date: Thu, 15 Oct 2026 22:36:11 +0200
Subject: [PATCH] avfilter/vf_scale_vulkan: fix height check for debayering

The check compared the width twice so a height-only change was not
rejected when debayering.

Found during a code review sweep of ffmpeg using an LLM.

Signed-off-by: romainhedouin <[email protected]>
---
 libavfilter/vf_scale_vulkan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_scale_vulkan.c b/libavfilter/vf_scale_vulkan.c
index c60f26acf5..1681ad1b50 100644
--- a/libavfilter/vf_scale_vulkan.c
+++ b/libavfilter/vf_scale_vulkan.c
@@ -367,7 +367,7 @@ static int scale_vulkan_config_output(AVFilterLink *outlink)
             av_log(avctx, AV_LOG_ERROR, "Unsupported output format for 
debayer\n");
             return AVERROR(EINVAL);
         }
-        if (inlink->w != outlink->w || inlink->w != outlink->w) {
+        if (inlink->w != outlink->w || inlink->h != outlink->h) {
             av_log(avctx, AV_LOG_ERROR, "Scaling is not supported with 
debayering\n");
             return AVERROR_PATCHWELCOME;
         }
-- 
2.54.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to