PR #25683 opened by Ramiro Polla (ramiro)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/25683
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/25683.patch


>From 14f17120f5a5810bf1215299571456fd4aaf5ee2 Mon Sep 17 00:00:00 2001
From: Ramiro Polla <[email protected]>
Date: Mon, 2 Nov 2026 15:53:09 +0100
Subject: [PATCH 1/3] configure: stop enabling fast_cmov for Loongson CPUs

HAVE_FAST_CMOV is only checked by x86 code (libavcodec/x86/cabac.h,
libavcodec/x86/vpx_arith.h, and the ARCH_X86 path in
libavcodec/dirac_arith.h), so enabling it for the MIPS-based Loongson
cores has no effect. This has been the case since the line was added
in 663321ed50.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Ramiro Polla <[email protected]>
---
 configure | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure b/configure
index 2fb600fbea4..3651f815547 100755
--- a/configure
+++ b/configure
@@ -5761,7 +5761,6 @@ elif enabled mips; then
                 enable simd_align_16
                 enable fast_64bit
                 enable fast_clz
-                enable fast_cmov
                 enable fast_unaligned
                 disable aligned_stack
                 # When gcc version less than 5.3.0, add 
-fno-expensive-optimizations flag.
-- 
2.54.0


>From a3981d677b9cb8d3b760786536a2861c2966c716 Mon Sep 17 00:00:00 2001
From: Ramiro Polla <[email protected]>
Date: Mon, 2 Nov 2026 15:58:01 +0100
Subject: [PATCH 2/3] configure: stop enabling fast_clz for Loongson CPUs

fast_clz_if_any includes mips, so fast_clz is already enabled for all
MIPS CPUs, Loongson included. This was already the case when the line
was added in 663321ed50: mips has been in fast_clz_if_any since
fast_clz was introduced in 669b558330, and nothing in the MIPS path
has ever disabled it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Ramiro Polla <[email protected]>
---
 configure | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure b/configure
index 3651f815547..6089f26133c 100755
--- a/configure
+++ b/configure
@@ -5760,7 +5760,6 @@ elif enabled mips; then
             loongson2e|loongson2f|loongson3*)
                 enable simd_align_16
                 enable fast_64bit
-                enable fast_clz
                 enable fast_unaligned
                 disable aligned_stack
                 # When gcc version less than 5.3.0, add 
-fno-expensive-optimizations flag.
-- 
2.54.0


>From 867d30598357d247d8900765f0d699251460ce0f Mon Sep 17 00:00:00 2001
From: Ramiro Polla <[email protected]>
Date: Mon, 2 Nov 2026 15:58:01 +0100
Subject: [PATCH 3/3] configure: stop disabling aligned_stack for Loongson CPUs

aligned_stack is only enabled through aligned_stack_if_any, which lists
aarch64, ppc and x86, so it is already disabled on MIPS. Besides,
HAVE_ALIGNED_STACK is only checked by x86 code. Both were already true
when the line was added in 663321ed50.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Ramiro Polla <[email protected]>
---
 configure | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure b/configure
index 6089f26133c..0468e7a08a3 100755
--- a/configure
+++ b/configure
@@ -5761,7 +5761,6 @@ elif enabled mips; then
                 enable simd_align_16
                 enable fast_64bit
                 enable fast_unaligned
-                disable aligned_stack
                 # When gcc version less than 5.3.0, add 
-fno-expensive-optimizations flag.
                 if test "$cc_type" = "gcc"; then
                     case $gcc_basever in
-- 
2.54.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to