On Fri, Sep 18, 2015 at 11:16 AM, Ganesh Ajjanagadde <gajja...@mit.edu> wrote: > On Fri, Sep 18, 2015 at 11:08 AM, wm4 <nfx...@googlemail.com> wrote: >> On 18.09.2015 15:09, Ganesh Ajjanagadde wrote: >>> >>> On Wed, Sep 16, 2015 at 8:26 PM, Ganesh Ajjanagadde >>> <gajjanaga...@gmail.com> wrote: >>>> >>>> Fixes -Wunused-function from >>>> >>>> http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 >>>> >>>> Signed-off-by: Ganesh Ajjanagadde <gajjanaga...@gmail.com> >>>> --- >>>> libavformat/hls.c | 13 ------------- >>>> 1 file changed, 13 deletions(-) >>>> >>>> diff --git a/libavformat/hls.c b/libavformat/hls.c >>>> index c16c770..2ea3a22 100644 >>>> --- a/libavformat/hls.c >>>> +++ b/libavformat/hls.c >>>> @@ -495,19 +495,6 @@ static int ensure_playlist(HLSContext *c, struct >>>> playlist **pls, const char *url >>>> return 0; >>>> } >>>> >>>> -static int open_in(HLSContext *c, AVIOContext **in, const char *url) >>>> -{ >>>> - AVDictionary *tmp = NULL; >>>> - int ret; >>>> - >>>> - av_dict_copy(&tmp, c->avio_opts, 0); >>>> - >>>> - ret = avio_open2(in, url, AVIO_FLAG_READ, c->interrupt_callback, >>>> &tmp); >>>> - >>>> - av_dict_free(&tmp); >>>> - return ret; >>>> -} >>>> - >>>> static int url_connect(struct playlist *pls, AVDictionary *opts, >>>> AVDictionary *opts2) >>>> { >>>> AVDictionary *tmp = NULL; >>>> -- >>>> 2.5.2 >>>> >>> >>> ping; wm4 basically did not like my old patch: see >>> https://ffmpeg.org/pipermail/ffmpeg-devel/2015-August/177769.html for >>> his thoughts and my response. Here, I delete as opposed to comment out >>> the lines. I personally do not care about deleting vs commenting out; >>> but one of the two should be used. >> >> >> If you think the inactive code is worth keeping, put it into a git branch or >> tag the commit removing the code.t > > I do not have write access, so I will leave it up to you (or anyone > else pushing) to either apply the old patch or this one (and possibly > tag it if desired).
See above for two possiblities on resolving this: either this patch (optionally tagging it), or simply commenting out the function (see above for link to old patch). Ping. > >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
