On Tue, Oct 6, 2015 at 6:55 PM, Ganesh Ajjanagadde <gajjanaga...@gmail.com> wrote: > This adds some recommendations while submitting patches that fix warnings. > > Signed-off-by: Ganesh Ajjanagadde <gajjanaga...@gmail.com> > --- > doc/developer.texi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index b8259e7..4d0fc9f 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -391,6 +391,12 @@ be changed to not generate a warning unless that causes > a slowdown > or obfuscates the code. > > @item > +While fixing compiler warnings, please add some information to the commit > +message body indicating the toolchain configuration. > +This is very helpful for future maintainers since it eases possible > +modifications when the toolchain gets updated. > + > +@item > Make sure that no parts of the codebase that you maintain are missing from > the > @file{MAINTAINERS} file. If something that you want to maintain is missing > add it with > your name after it. > -- > 2.6.1 >
Anyone thinks this is useful? I can't really say: regular developers anyway know this, and drive-by/sporadic contributions are highly unlikely to be warning fixes. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel