On Sat, Oct 24, 2015 at 1:23 PM, Michael Niedermayer <[email protected]> wrote: > On Sat, Oct 24, 2015 at 09:28:52AM -0400, Ganesh Ajjanagadde wrote: >> ISO C does not guarantee that functions and data live in the same >> address space. It is thus (strictly speaking) illegal to assign to a >> void * (which is a data pointer) from a function pointer. >> >> Found by enabling -Wpedantic on clang 3.7. >> >> Signed-off-by: Ganesh Ajjanagadde <[email protected]> >> --- >> ffmpeg_opt.c | 8 ++++---- >> libavcodec/hevc.c | 2 +- >> libavfilter/vf_drawtext.c | 2 +- >> libavfilter/vf_lut.c | 6 +++--- >> libavformat/async.c | 2 +- >> 5 files changed, 10 insertions(+), 10 deletions(-) > > if these dont add any new warnings then LGTM > but the commit message should rather point to code cleanup and > not ISO C
They do not add warnings as far as I can tell (under standard warning flags). Reworded message to reflect that it represents a cleanup, and pushed. Thanks. > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > The bravest are surely those who have the clearest vision > of what is before them, glory and danger alike, and yet > notwithstanding go out to meet it. -- Thucydides > > _______________________________________________ > ffmpeg-devel mailing list > [email protected] > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
