On Sat, 2015-11-28 at 09:45 -0500, Ganesh Ajjanagadde wrote:
>
> Removed the av_cold, did not find a way to cleanly get rid of the
> inline. I do suggest giving it some thought; it is needless
> executable
> bloat since the inline does not help perf. Pushed, thanks.
>
Hardly a blot as it's really only used twice in the entire code and the
function isn't a particularly big one. Moreover even if it was a big
function used in a few more places GCC can and will magically uninline
it (which is why I'm not really a fan of using av_always_inline for
every single function which has to be inlined, better to let the
compiler figure it out and if it can't it'll just inline it anyway).
But I digress, the whole point of inlining this particlar function was
so it could be put inside the header and not inside aactab.c (which
contains no executable code at all).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
