On 02.12.2015 15:54, Vicente Olivert Riera wrote: > On 20/11/15 20:10, Andreas Cadhalpun wrote: >> If the cpu is not explicitly set via configure options, it is set to generic. >> Removing this generic case here, will force-disable all mips optimizations, >> even if they were explicitly enabled with configure options. >> That would e.g. break how the Debian ffmpeg package is built for mips64el. > > Aha, I see. > > But I don't understand why msa is disabled for a generic cpu and not the > dsp or dspr2.
That was added in commit 8af3ce5, with the following comment: "MIPS 'generic' case is added, with mips32r2 arch as default (fpu and dsp opt enabled)." I'm not sure why this combination was chosen for the generic case. > Either we disable everything, or nothing. But just > disabling features randomly doesn't make any sense, at least for me. > > What about this? > > generic) > # We don't disable anything. Is up to the user to > # disable the unwanted features. > ;; That would be fine with me. > *) > # Unknown CPU. Disable everything. I think it would be good if configure printed a warning in this case. > disable mipsfpu > disable mips32r2 > ... > ;; Best regards, Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
