On Thu, Dec 10, 2015 at 11:01 AM, Ivan Uskov <ivan.us...@nablet.com> wrote: > Hello Hendrik, > > Thursday, December 10, 2015, 12:19:23 PM, you wrote: > > HL> On Thu, Dec 10, 2015 at 10:16 AM, Sven Dueking <s...@nablet.com> wrote: >>> This patch expose 3 QSV functions as public. >>> This is needed because the VPP needs access to these functions too. >>> >>> Please review. >>> > > HL> public API is not allowed to use config.h, it needs to be config and > HL> OS agnostic. > Any qsv_* function can not be public since are all under CONFIG_QSV, correct? >
Thats not necessarily true, if its supposed to be public API, it just has to always be present, so it would have to be changed to just do nothing and return an error if QSV is not enabled, but the functions still exist. Using config.h in public headers is not something you can somehow work around however. The public interface needs to be stable, independent of how ffmpeg was built. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
