On 1/10/2016 1:54 AM, James Almer wrote: >> +AVCodec ff_cfhd_decoder = { >> + .name = "cfhd", >> + .long_name = NULL_IF_CONFIG_SMALL("Cineform HD"), >> + .type = AVMEDIA_TYPE_VIDEO, >> + .id = AV_CODEC_ID_CFHD, >> + .priv_data_size = sizeof(CFHDContext), >> + .init = cfhd_decode_init, >> + .close = cfhd_close_decoder, >> + .decode = cfhd_decode, >> + .capabilities = AV_CODEC_CAP_EXPERIMENTAL | AV_CODEC_CAP_DR1 | >> AV_CODEC_CAP_FRAME_THREADS, > > Unless the decoder is prone to crash, i don't think setting it as > experimental is > a good idea. I assume most players out there will not use it because of that > flag.
>> +/* some special codewords, not sure what they all mean */ >> +#define TABLE_9_BAND_END1 0x1C7859Eh >> +#define TABLE_9_BAND_END_LEN1 25 >> +#define TABLE_9_BAND_END2 0x38F0B3Fh >> +#define TABLE_9_BAND_END_LEN2 26 >> +#define TABLE_9_BAND_END3 0x38F0B3Eh >> +#define TABLE_9_BAND_END_LEN3 26 > > All these are unused. It stands to reason they shall be used the the future. Perhaps they can be added to multimediawiki? >> + .id = AV_CODEC_ID_CFHD, >> + .type = AVMEDIA_TYPE_VIDEO, >> + .name = "cfhd", >> + .long_name = NULL_IF_CONFIG_SMALL("Cineform HD"), > > Missing .props Internal props too (thread safe init pls!). - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel