On 2/4/2016 2:12 AM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
> ---
> libavcodec/libutvideoenc.cpp | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
My personal preference, and that shared by every single person I've
asked, is that we removed this.
As it stands:
- Upstream libutvideo doesn't build as a lib, and Linux is not supported.
- The fork that was used as an argument to keep support is *also* broken and
unmaintained now, and it's maintainer/author is fine with removal.
- A third fork on github, *also* doesn't work.
- The only working library that I can find is a package for an obscure distro,
in German only, with a bunch of patches applied.
- The ASM in libutvideo doesn't even work on x86_64.
- More, I'm sure others can fill in.
> --- a/libavcodec/libutvideoenc.cpp
> +++ b/libavcodec/libutvideoenc.cpp
> @@ -229,9 +229,9 @@ static av_cold int utvideo_encode_close(AVCodecContext
> *avctx)
> #define OFFSET(x) offsetof(UtVideoContext, x)
> #define VE AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM
> static const AVOption options[] = {
> - { "pred", "Prediction method", OFFSET(pred), AV_OPT_TYPE_INT, 0, 0, 2,
> VE, "pred" },
> - { "left", NULL, 0, AV_OPT_TYPE_CONST, 0, INT_MIN, INT_MAX, VE, "pred"
> },
> - { "median", NULL, 0, AV_OPT_TYPE_CONST, 2, INT_MIN, INT_MAX, VE,
> "pred" },
> + { "pred", "Prediction method", OFFSET(pred), AV_OPT_TYPE_INT, {i64: 0},
> 0, 2, VE, "pred" },
> + { "left", NULL, 0, AV_OPT_TYPE_CONST, {i64: 0}, INT_MIN, INT_MAX, VE,
> "pred" },
> + { "median", NULL, 0, AV_OPT_TYPE_CONST, {i64: 2}, INT_MIN, INT_MAX,
> VE, "pred" },
Is this even valid C++, or some GNU extension?
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
