On Tue, 01 Mar 2016 14:57:29 +0000
Timothy Gu <timothyg...@gmail.com> wrote:
> Hi,
>
> On Mon, Feb 29, 2016 at 9:42 PM Rick Kern <ker...@gmail.com> wrote:
>
> > Autodetected by default. Encode using -codec:v vtenc.
> >
> > Signed-off-by: Rick Kern <ker...@gmail.com>
> > ---
> > MAINTAINERS | 1 +
> > configure | 19 +
> > libavcodec/Makefile | 1 +
> > libavcodec/allcodecs.c | 1 +
> > libavcodec/vtenc.c | 1339
> > ++++++++++++++++++++++++++++++++++++++++++++++++
> > 5 files changed, 1361 insertions(+)
> > create mode 100644 libavcodec/vtenc.c
> >
>
> We already have videotoolbox AVHWAccel. Maybe it would be better to change
> the name of the file to videotoolboxenc.c so that it's easier to associate
> these two files?
I don't mind. They're pretty different after all.
>
> > +AVCodec ff_vtenc_encoder = {
>
> > + .name = "vtenc",
> > + .long_name = NULL_IF_CONFIG_SMALL("VideoToolbox H.264
> > Encoder"),
> >
>
> The norm seems to be using "h264_videotoolbox" (like "h264_qsv") so that
> potential future extensions to VideoToolbox can be supported without
> changing the name of the codec.
>
Good point.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
