On Wed, 13 Apr 2016 14:14:37 +0600 nablet developer <s...@nablet.com> wrote:
> > Why would this API need to be exported? > > previously QuickSync was used only by libavcodec and its components - e.g. > there are QSV encoder and decoders for AVC and MPEG-2. so it was OK that > QuickSync initialisation and cleanup functions were local for libavcodec. > > but right now we're adding QuickSync VPP component to libavfilter, so > mentioned functions now become shared at least between libavcodec and > libavfilter. > therefore, patch to add QSV VPP filter was rejected because it accessed > libavcodec functions which were local, and it was suggested that such > functions are need to be exported from libavcodec, so libavfilter can use > them. Wouldn't it be better to keep it internal then? Sharing code between the sub-libs is unfortunately messy, but possible. For example, you could create a dummy .c file in libavfilter that includes the libavcodec one. Not beautiful, but might be better than making the API public. Not sure what other devs think about this. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
