I think only the 2 first patches are needed, but I prefer the code from the 3rd+4th patches. Overall, it's still not the nicest code, and valgrind-proofing the patchset is needed (not possible atm for me).
The SSE4 implementation is not worthwhile in my opinion. Christophe Gisquet (6): fate: wma: add lossless 24bits test wmalossless: allow calling madd_int16 wmalossless pro: move lms_update wmalossless: template code to remove inloop if x86: lossless audio: SSE4 madd 32bits lossless audio dsp: unroll libavcodec/lossless_audiodsp.c | 12 ++- libavcodec/wmalosslessdec.c | 137 ++++++++++++++++++++------------ libavcodec/x86/lossless_audiodsp.asm | 38 +++++++++ libavcodec/x86/lossless_audiodsp_init.c | 7 ++ tests/fate/lossless-audio.mak | 4 +- tests/ref/fate/lossless-wma24 | 1 + 6 files changed, 143 insertions(+), 56 deletions(-) create mode 100644 tests/ref/fate/lossless-wma24 -- 2.8.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel