On 04/21/2016 12:14 AM, Nicolas George wrote:
Le duodi 2 floréal, an CCXXIV, sebechlebsky...@gmail.com a écrit :
+ if (av_strerror(err_n, errbuf, sizeof(errbuf)) < 0)
+ errbuf_ptr = strerror(AVUNERROR(err_n));
strerror() should not be used, even though a few places still use it.
Furthermore, there is no reasonable reason for av_strerror() to fail and
strerror() to succeed.
I suggest you use av_err2str(), like the rest of the modern FFmpeg code.
I did not look at the rest of the patch, under the assumption that only this
bit changed. If not, please tell me (and in the future write it in the
comment part of the Git mail).
Also, no need to Cc me, I am subscribed to the list; just following the
reply-to as is normally done by default should be good.
I will look at the other patch soon.
Regards,
Thanks for feedback,
I've checked how the error string is retrieved in the use case you've
posted (print_error in cmdutils.c which is called from ffmpeg.c) so
that's why I used av_strerror together with strerror.
I'll send modified patch with av_err2str.
Only thing changed in the patch apart from the discussed change was,
that I've removed forgotten unused variable avf2 declaration in
tee_write_trailer function from patch.
I'll remeber to note changes next time in the comment.
Regards,
Jan S.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
