On Sat, Apr 23, 2016 at 10:26:27PM +0200, Martin Vignali wrote: > 2016-04-13 19:07 GMT+02:00 Michael Niedermayer <mich...@niedermayer.cc>: > > > On Wed, Apr 13, 2016 at 06:48:33PM +0200, Martin Vignali wrote: > > > 2016-04-13 16:45 GMT+02:00 Michael Niedermayer <mich...@niedermayer.cc>: > > > > > > > On Wed, Apr 13, 2016 at 01:53:08PM +0200, Martin Vignali wrote: > > > > > Hello, > > > > > > > > > > In attach a patch to add fate test for piz compression (not cover > > now). > > > > > > > > > > Samples can be found here : https://we.tl/9WadnNpF4t > > > > > (and need to be put inside fate-suite/exr) > > > > > > > > > > rgb_scanline_half_piz_bw : Replicate trouble of ticket #3932 > > > > > rgb_scanline_half_piz_color : a more common piz file > > > > > rgb_scanline_half_piz_dw_t01 : the official sample > > > > ./DisplayWindow/T01.exr > > > > > (who use a different part of the decompression (see recent patch for > > > > > fix_huf_decode). > > > > > > > > > > Martin > > > > > Jokyo Images > > > > > > > > > fate/image.mak | 9 +++++++++ > > > > > ref/fate/exr-rgb-scanline-half-piz-bw | 2 ++ > > > > > ref/fate/exr-rgb-scanline-half-piz-color | 2 ++ > > > > > ref/fate/exr-rgb-scanline-half-piz-dw-t01 | 2 ++ > > > > > 4 files changed, 15 insertions(+) > > > > > fe8ab21d9568a451293fd902b14da6bc9ed852b0 > > > > 0001-fate-exr-add-test-for-piz-compression.patch > > > > > From cbef05fca746de42340f7d60a6ff852548f364f9 Mon Sep 17 00:00:00 > > 2001 > > > > > From: Martin Vignali <martin.vign...@gmail.com> > > > > > Date: Wed, 13 Apr 2016 13:01:56 +0200 > > > > > Subject: [PATCH] fate/exr : add test for piz compression > > > > > > > > samples uploaded but this fails on mips-qemu > > > > > > > > > > > > TEST exr-rgb-scanline-half-piz-bw > > > > TEST exr-rgb-scanline-half-piz-color > > > > TEST exr-rgb-scanline-half-piz-dw-t01 > > > > --- > > > > > > /home/michael/ffmpeg-git/ffmpeg/tests/ref/fate/exr-rgb-scanline-half-piz-bw > > > > 2016-04-13 16:26:58.893613229 +0200 > > > > +++ tests/data/fate/exr-rgb-scanline-half-piz-bw 2016-04-13 > > > > 16:44:08.297634915 +0200 > > > > @@ -1,2 +1,2 @@ > > > > #tb 0: 1/25 > > > > -0, 0, 0, 1, 5508, 0x36d15e2e > > > > +0, 0, 0, 1, 5508, 0x00000000 > > > > Test exr-rgb-scanline-half-piz-bw failed. Look at > > > > tests/data/fate/exr-rgb-scanline-half-piz-bw.err for details. > > > > make: *** [fate-exr-rgb-scanline-half-piz-bw] Error 1 > > > > make: *** Waiting for unfinished jobs.... > > > > --- > > > > > > /home/michael/ffmpeg-git/ffmpeg/tests/ref/fate/exr-rgb-scanline-half-piz-color > > > > 2016-04-13 16:26:58.901613228 +0200 > > > > +++ tests/data/fate/exr-rgb-scanline-half-piz-color 2016-04-13 > > > > 16:44:08.309634916 +0200 > > > > @@ -1,2 +1,2 @@ > > > > #tb 0: 1/25 > > > > -0, 0, 0, 1, 8160, 0x9dd67b7d > > > > +0, 0, 0, 1, 8160, 0x6b40d3ab > > > > Test exr-rgb-scanline-half-piz-color failed. Look at > > > > tests/data/fate/exr-rgb-scanline-half-piz-color.err for details. > > > > make: *** [fate-exr-rgb-scanline-half-piz-color] Error 1 > > > > --- > > > > > > /home/michael/ffmpeg-git/ffmpeg/tests/ref/fate/exr-rgb-scanline-half-piz-dw-t01 > > > > 2016-04-13 16:26:58.917613229 +0200 > > > > +++ tests/data/fate/exr-rgb-scanline-half-piz-dw-t01 2016-04-13 > > > > 16:44:08.437634918 +0200 > > > > @@ -1,2 +1,2 @@ > > > > #tb 0: 1/25 > > > > -0, 0, 0, 1, 720000, 0xe50fc9f8 > > > > +0, 0, 0, 1, 720000, 0x00000000 > > > > Test exr-rgb-scanline-half-piz-dw-t01 failed. Look at > > > > tests/data/fate/exr-rgb-scanline-half-piz-dw-t01.err for details. > > > > make: *** [fate-exr-rgb-scanline-half-piz-dw-t01] Error 1 > > > > > > > > [...] > > > > > > > > > > > > That's annoying. Will be hard for me to test what's wrong with MIPS. > > > > > > Just to be sure, do you use the latest git, with the latest patch from > > Apr > > > 12, 2016 for this tests > > > Because these 3 samples doesn't have the right result before theses > > patchs. > > > > fate passes on x86 so i assume all patches are in > > > > > > > > > > Is it possible to have an output example of theses 3 exr files, in png > > for > > > example, maybe it can help to know the source of the problem. > > > > attached, 2 of them are black (the checksum of all 0 also hints toward > > that) > > > > Do you will consider as an option, to disable exr piz decompression on mips > (mark it as unsupported), > waiting someone enough brave to adapt it on this platform. > > Seeing decoding error, i think it doesn't work at all now on mips > > So piz can be cover by fate-tests reducing the risk of regression on x86.
if the code is valid C code then it should work on MIPS you can test the code on MIPS with qemu-mips [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
