On Mon, May 16, 2016 at 02:31:20PM +0200, Paul B Mahol wrote: > On 5/16/16, Michael Niedermayer <mich...@niedermayer.cc> wrote: > > Fixes undefined behavior in fate-lossless-wma24-2 > > > > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > > --- > > libavcodec/lossless_audiodsp.c | 4 ++-- > > libavcodec/wmalosslessdec.c | 6 +++--- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > > You sure this doesn't introduce artifacts?
It only changes cases that are undefined in C, so before this patch its certainly wrong as different compilers with different options will do different things (thats how i found it) see http://fatebeta.ffmpeg.org/report/x86_64-freebsd10-clang33-ftrapv/20160515224104#failed_tests If its as intended after the patch i dont know. I hoped somone would know when seeing the patch, thats why i posted it ... but fate still passes and all the changed cases are from fate testcases [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 3 "Rare item" - "Common item with rare defect or maybe just a lie" "Professional" - "'Toy' made in china, not functional except as doorstop" "Experts will know" - "The seller hopes you are not an expert"
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
