2016-05-13 11:48 GMT+02:00 foo86 <fooba...@gmail.com>: > - unsigned int v = get_unary(gb, 1, 128); > + unsigned int v = get_unary(gb, 1, get_bits_left(gb));
Not that the patch is not ok, but I have a few uneducated questions: 1) Given the get_bits_long(gb, k) afterwards, won't that code cause overreads for corrupted bitstreams? 2) I haven't checked the calling code, but consequently, wouldn't it be better to first check that at least k+1 bits are available? 3) 128 is already fairly large; is the new code for valid bitstreams (in the sense of specs and actually generated) or for corrupted bitstreams? I don't know where the parsing is validated afterwards (e.g. if there have been overreads or invalid values parsed) Thanks, -- Christophe _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
