skip_samples shouldn't be negative. But it's not enforced because it is an int field. Changed the condition to equality. Added an assert where skip_samples is populated.
On Sun, Aug 14, 2016 at 5:40 AM, Clément Bœsch <u...@pkh.me> wrote: > On Tue, Aug 09, 2016 at 06:48:21PM -0700, Sasi Inguva wrote: > [...] > > + if ((frame->flags & AV_FRAME_FLAG_DISCARD) && > avctx->internal->skip_samples <= 0) { > > skip_samples can be negative? > > if so, that looks like a behaviour change we want documented > > if not, you probably want to check against 0 equality and add an assert. > > -- > Clément B. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel