On 8/25/2016 1:46 PM, Derek Buitenhuis wrote: > On 8/25/2016 5:34 PM, James Almer wrote: >> On 8/25/2016 12:45 PM, Carl Eugen Hoyos wrote: >>> 2016-08-24 16:55 GMT+02:00 Derek Buitenhuis <derek.buitenh...@gmail.com>: >>>> This breaks files with legitimate single-entry edit lists, >>> >>>> and the hack, introduced in f03a081df09f9c4798a17d7e24446ed47924b11b, >>> >>> I believe "Hack" is not acceptable on this mailing list anymore, please >>> remove it from the commit message. >> >> Care to point where this was discussed or agreed by the bulk of developers? >> I don't recall anything about it. >> A quick search for "hack" shows a lot of recent results in both the ML and >> the git repo, so I'm not sure why you assumed it's "not acceptable" anymore. > > What's a better word? "incorrect workaround"? Am I not allow to say > some code is wrong? Because the code is defacto incorrect.
Hack is perfectly fine. But if you want to change it, saying it's a faulty, wrong or incorrect workaround is also fine. > >> >>> >>>> has no link to any known sample in its commit message >>> >>> I believe a sample is linked in the original commit message, >>> please remove the sentence. > > It is not. A filename is not a link. There is no way to locate the > sample solely from the commit message. The description is accurate. > > - Derek > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
