On Mon, Aug 29, 2016 at 02:23:44PM -0700, Brett Harrison wrote: > Before I fix the patch, can you clarify the intended functionality? > > The docs say that 16 is the default fontsize, however if > CONFIG_LIBFONTCONFIG is configured and ffmpeg if called with: > > -vf drawtext=text=abc:fontcolor=white > > on my system the font used will be /opt/X11/share/fonts/TTF/Vera.ttf (the > default chosen by libfontconfig) and the fontsize will be set to 12. > > However if ffmpeg is called with: > > -vf > drawtext=text=abc:fontcolor=white:fontfile=/opt/X11/share/fonts/TTF/Vera.ttf > > This is the same font that libfontconfig used, however this time fontsize > 16 is used as stated in the docs. > > The difference is this line of code in load_font_fontconfig > if (!s->fontsize) > s->fontsize = size + 0.5; >
> I didn't set the fontsize in either command, but the output was different. > Do we want to keep this as is? I think no can you send a seperate patch that changes this ? (it should really not change as a sideeffect of this patch) [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
