On Tue, Aug 30, 2016 at 10:54 AM, Paul B Mahol <one...@gmail.com> wrote: > > > On Tuesday, August 30, 2016, Vittorio Giovara <vittorio.giov...@gmail.com> > wrote: >> >> On Tue, Aug 30, 2016 at 4:13 AM, Paul B Mahol <one...@gmail.com> wrote: >> > >> > >> > On Mon, Aug 29, 2016 at 5:53 PM, Ronald S. Bultje <rsbul...@gmail.com> >> > wrote: >> >> >> >> Hi, >> >> >> >> On Mon, Aug 29, 2016 at 11:23 AM, Vittorio Giovara < >> >> vittorio.giov...@gmail.com> wrote: >> >> >> >> > The filter needs input frames with color properties filled out by >> >> > the decoder. Since this is not always possible, add input options to >> >> > the filter so that user may override color space, color primaries, >> >> > transfer characteristics, and color range, as well as a generic >> >> > option >> >> > to set all properties at once. >> >> > >> >> > Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> >> >> > --- >> >> > * added iall option >> >> > * updated filter documentation >> >> > >> >> > Please CC. >> >> > Vittorio >> >> > >> >> > doc/filters.texi | 20 ++++++++++++++++++++ >> >> > libavfilter/vf_colorspace.c | 39 >> >> > ++++++++++++++++++++++++++++++++++----- >> >> > 2 files changed, 54 insertions(+), 5 deletions(-) >> >> >> >> >> >> lgtm. >> >> >> >> (I wonder if the error message - if the input AVFrame has no >> >> trc/rng/csp/prm - should be changed to reflect that you can override >> >> them >> >> using the added properties? This isn't a big deal but maybe someone >> >> feels >> >> that's important.) >> > >> > >> > Still breaks backward compatibility. >> >> I fail to see how, can you provide more details? > > > > when doing options without typing option name, but just values, like: > val0:val1:...
Oh I see, thanks. Isn't that syntax a little too fragile for this kind of filter? Or, from another perspective, is the filter old enough that backward compatibility should matter? -- Vittorio _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
