On 14/09/2016 17:17, Carl Eugen Hoyos wrote:
2016-09-11 23:14 GMT+02:00 Josh de Kock <j...@itanimul.li>:

+    { AV_PIX_FMT_RGB24,  SDL_PIXELFORMAT_RGB888 },

+    { AV_PIX_FMT_BGR24,  SDL_PIXELFORMAT_BGR888 },

Did you test them / why did you remove the comments that said
they do not work?

I assumed since no one complained they were correct. (The comments were just asking if they were correct mappings or not).

+    { AV_PIX_FMT_RGB0,   SDL_PIXELFORMAT_RGBX8888 },
+    { AV_PIX_FMT_BGR0,   SDL_PIXELFORMAT_BGRX8888 },
+    { AV_PIX_FMT_ARGB,   SDL_PIXELFORMAT_ARGB8888 },
+    { AV_PIX_FMT_RGBA,   SDL_PIXELFORMAT_RGBA8888 },
+    { AV_PIX_FMT_ABGR,   SDL_PIXELFORMAT_ABGR8888 },
+    { AV_PIX_FMT_BGRA,   SDL_PIXELFORMAT_BGRA8888 },

These are wrong afaict, I am happy to fix them after this gets
committed if you are less interested.


That would be much appreciated, I wasn't too sure about the mappings, so if you could look over all of them that'd be great.

--
Josh
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to