On 30 September 2016 at 14:16, Rostislav Pehlivanov <atomnu...@gmail.com> wrote:
> > > On 29 September 2016 at 21:54, Josh de Kock <j...@itanimul.li> wrote: > >> There is really no need for two aac wrappers, we already have >> libfdk-aac which is better. Not to mention that faac doesn't >> even support HEv1, or HEv2. It's also under a license which is >> unusable for distribution, so it would only be useful to people >> who will compile their own ffmpeg, only use it themselves (which >> at that point should just use fdk-aac). >> >> Signed-off-by: Josh de Kock <j...@itanimul.li> >> --- >> >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > > > Hi, > > Thanks for the patch, I'll push it tomorrow. > Enough discussions have taken place that dealing with the aftermath of > removing it will actually be easier than continuing the 6 month discussions > that have been taking place. > Our decoder is much faster than it (using the -aac_coder fast option) and > still has much much better quality. Testcases are useless because libfaac > does nothing right, especially in terms of bitstream compliance. And like > wm4 mentioned, libfaac has license issues too. > Pushed I'm looking at trac to see what needs a faac sample as a fate test, but if anyone's bored they're welcome to join me :) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
