Hi, On Fri, Oct 14, 2016 at 2:09 PM, James Zern <jz...@google.com> wrote:
> Ronald, > > On Fri, Oct 14, 2016 at 10:01 AM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: > > This is intended to workaround bug "665 Integer Divide Instruction May > > Cause Unpredictable Behavior" on some early AMD CPUs, which causes a > > div-by-zero in this codepath, such as reported in Mozilla bug #1293996. > > > > Note that this isn't guaranteed to fix the bug, since a compiler is free > > to reorder instructions that don't depend on each other. However, it > > appears to fix the bug in Firefox, and a similar patch was applied to > > libvpx also (see Chrome bug #599899). > > > > I recently made a few additional changes as this regressed in chrome > [1][2], but just like this change there's no guarantee it won't occur > again. > > [1] https://chromium.googlesource.com/webm/libvpx/+/ > 8b4210940ce4183d4cfded42c323612c0c6d1688 > [2] https://chromium.googlesource.com/webm/libvpx/+/ > 82ea74223771793628dbd812c2fd50afcfb8183a > > > --- > > libavcodec/vp9.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > lgtm (Firefox beta crash reports confirmed that the bug is fixed.) Pushed. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel