On Sun, Dec 25, 2016 at 11:34:16AM +0100, Nicolas George wrote: > Le quintidi 5 nivôse, an CCXXV, Michael Niedermayer a écrit : > > after one quick pass looking through this i have mainly one request > > please seperate functions intended to be used by filters from functions > > intended to be used by the core. Maybe by using 2 seperate headers. > > I had started to do that with the name of the functions: > > The ff_link_* functions are meant to be used by filters. Now, I realize > I would like to rename them ff_inlink_* for the ones in this patch > series, that are used by the filters on their input links, and call > ff_outlink_* the ones for their output links. > > The *_to_filter functions are the implementation of the default activate > callback, i.e. the callback that wraps the current filter_frame / > request_frame callbacks. This is not entirely consistent, I should > probably make a few cosmetic patches to rename them and group them. >
> I suppose you have no objection to having functions meant for filters > used by the core too if they fit the need exactly? no objection > > Do you have a suggested name for a separate header? hmm, maybe core.h or lavfi_core.h and filters.h maybe spliting it up into more headers will make sense, i dont know [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
