On Mon, Jan 02, 2017 at 02:24:22PM +0100, Bodecs Bela wrote:
>
>
> 2017.01.02. 13:54 keltezéssel, Moritz Barsnick írta:
> >On Mon, Jan 02, 2017 at 12:49:50 +0100, Bodecs Bela wrote:
> >>Subject: [FFmpeg-devel] [PATCH] doc/hlsenc: hls_segment_filename,
> >>use_localtime, , use_localtime_mkdir, hls_flags
> >
> > ^^
> >There's a ", " too much in that part of the commit message.
> >
> >>+@var{filename} may contain full path or relative path specification, but
> >>only the file name part without any path info will be contained in the m3u8
> >>segment list.
> >You should break this line.
> >
> >>+Should relative path is specified, path of created segment files will be
> >>relative to the current working directory.
> >->
> > Should a relative path be specified, the path of the created segment
> > files will be relative to the current working directory.
> >
> >>+When -use_localtime_mkdir is set, the whole expanded value of
> >>@var{filename} will be written into m3u8 segment list.
> > ^ I think you should omit the dashes, as these are primarily
> > library options, not command line options.
> >
> >And do add an article: "... will be written into the m3u8 segment
> >list."
> >
> >>-@file{file-20160215-1455569023.ts}, @file{file-20160215-1455569024.ts},
> >>etc.
> >>+@file{file-20160215-1455569023.ts}, @file{file-20160215-1455569024.ts},
> >>etc. (Notice: in some systems/environments %s specifier is not available.
> >>See strftime() documentation!)
> >->
> > Note: On some systems/environments, the code{%s} specifier is not
> > available. See
> > code{strftime()} documentation.
> >
> >(Avoid exclamation marks.)
> >
> >>+This example will create a directory hierarchy 2016/02/15 (if any of them
> >>does not exist), and then
> >
> > ^ do
> Thank you. I have made all suggested changes.
> >Moritz
> >_______________________________________________
> >ffmpeg-devel mailing list
> >ffmpeg-devel@ffmpeg.org
> >http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > muxers.texi | 47 +++++++++++++++++++++++++++++++++++------------ > 1 file changed, 35 insertions(+), 12 deletions(-) > c0e3481cbb64139648b9138baea7b18ce75c7de8 > 0001-doc-muxers-hls_segment_filename-use_localtime-use_lo.patch > From 2720f2410feb9c51a6d37477f432780dc2594c5d Mon Sep 17 00:00:00 2001 > From: Bela Bodecs <bode...@vivanet.hu> > Date: Sun, 1 Jan 2017 22:48:27 +0100 > Subject: [PATCH] doc/muxers: hls_segment_filename, use_localtime, > use_localtime_mkdir, hls_flags seems this was already approved by steven and this fixes all issues found by Moritz so applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
