On Sat, 1 Apr 2017 10:01:15 +0200 Nicolas George <geo...@nsup.org> wrote:
> Le primidi 11 germinal, an CCXXV, Steven Liu a écrit : > > I think just similar, not duplicating, and the simple functionality use > > BPrint maybe too complex. > > Well, I will say it unambiguously: > > Parts of this patch DO duplicate logic that we already have, and your > statement about BPrint being too complex is simply completely wrong. The bprint API is somewhat complicated. > Therefore, it was not acceptable as is and should not have been pushed. > > Pushing while leaving only half a day to answer this was UNACCEPTABLE. > Do not ever do it again please. Why get upset over a simple function being added? Lots of unreviewed patches or patches that were half-approved or not really approved get pushed. That's how this project work. If you don't like it, propose a rule change. > Now, I will not insist on reverting, but I will demand that you make a > priority of simplifying this code. It's already maximally self-contained. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
