On 03.08.2017 10:41, Steinar H. Gunderson wrote:
On Thu, Aug 03, 2017 at 08:21:09AM +0300, Maksym Veremeyenko wrote:
You should reject bottom field first formats, as NDI explicitly
disallows them.
even if it disallowed, why to drop? may be warning message would be enough?
FWIW, the documentation may say that formats are always TFF, but on the wire,
it seems the bottom field actually goes first.
(I guess this is a bug that isn't noticed because there's actually no way
from the API to get at the individual fields)
i dropped bottom field order support.
+NDI is very picky about the formats it supports. Pixel format is always
+uyvy422.
Or bgra (internally, uyvya4224, I suppose).
i extended supported pixel format, except uyvya4224 that is not
supported by ffmpeg
+ recv_create_desc.allow_video_fields = ctx->allow_video_fields;
I'm not convinced you ever want to set this to false, as what's happening if
you do is simply that the SDK applies a vertical blur to incoming interlaced
frames. FFmpeg has much better deinterlacers if that's what you want.
i dont know which method used by SDK to deinterlace, but if it provided,
then it could be used for some reason.
--
Maksym Veremeyenko
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
