On Wed, Sep 06, 2017 at 10:05:40PM +0200, Thilo Borgmann wrote: > Hi, > > Am 06.09.17 um 11:58 schrieb Clément Bœsch: > > From: Clément Bœsch <cboe...@gopro.com> > > > > $headers is a variable set in the context of other functions (we don't > > use the "local" keyword in our scripts, so those variables are global). > > > > Currently, when checking for AVFoundation/AVFoundation.h, the actual > > enabled header is math.h. > > > > Similarly, when testing for QuartzCore/CoreImage.h, the actual enabled > > header is CoreGraphics/CoreGraphics.h. > > > > This is completely broken and may be the reason why these checks are > > made in random places. > > thus it was just a typo like the patch 1 suggested? >
What do you mean by "like the patch 1 suggested"? This is the patch 1. And yeah, I guess it's a typo from day 1 (a2c6a99ba5). I didn't check if the code was valid back then thanks to a side effect (basically if check_cc was setting headers=$1 somewhere), but it's definitely broken currently. > Patch 1-5 ok! > For patch 6-7 maybe someone else can have a closer look. I'll wait a little more and push the patchset. Thanks -- Clément B.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
