2017-10-24 12:35 GMT+02:00 <developm...@axeltechnology.com>:
> >From 2a657145a9b6bbbbbc2c1beb450100fe2d4d80ee Mon Sep 17 00:00:00 2001
> From: "Axel Technology" <developm...@axeltechnology.com>
> Date: Mon, 23 Oct 2017 18:02:58 +0200
> Subject: [PATCH] Sony XDCAM Fix
>
> Signed-off-by: Axel Technology <developm...@axeltechnology.com>
> ---
> libavformat/mxfenc.c | 112
> ++++++++++++++++++++++++++++++---------------------
> 1 file changed, 66 insertions(+), 46 deletions(-)
>
> [...]
> - // MPEG video Descriptor
> - { 0x8000,
> {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x01,0x06,0x02,0x01,0x0B,0x00,0x00}},
> /* BitRate */
> - { 0x8007,
> {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x01,0x06,0x02,0x01,0x0A,0x00,0x00}},
> /* ProfileAndLevel */
> + { 0x8003,
> {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x01,0x06,0x02,0x01,0x05,0x00,0x00}},
> /* LowDelay */
> + { 0x8004,
> {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x01,0x06,0x02,0x01,0x06,0x00,0x00}},
> /* ClosedGOP */
> + { 0x8006,
> {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x01,0x06,0x02,0x01,0x08,0x00,0x00}},
> /* MaxGOP */
> + { 0x8007,
> {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x01,0x06,0x02,0x01,0x09,0x00,0x00}},
> /* BPictureCount */
> + { 0x8008,
> {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x01,0x06,0x02,0x01,0x0A,0x00,0x00}},
> /* ProfileAndLevel*/
> + { 0x8009,
> {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x01,0x06,0x02,0x01,0x0B,0x00,0x00}},
> /* BitRate */
>
>
You modified the tags for BitRate and ProfileAndLevel, but didn´t adapt the
mxf_write_mpegvideo_desc function. The other UIDs you added aren´t used
elsewhere.
They could be used within the mxf_write_mpegvideo_desc function function,
as Maksym did in his patch.
@@ -1823,7 +1838,6 @@ static const struct {
> int profile;
> uint8_t interlaced;
> } mxf_h264_codec_uls[] = {
> - {{
> 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0a,0x04,0x01,0x02,0x02,0x01,0x31,0x11,0x01
> }, 0, 66, 0 }, // AVC Baseline, Unconstrained Coding
>
>
This seems unrelated. In any case AVC Baseline support should not be
dropped.
@@ -2254,6 +2273,7 @@ static void mxf_write_system_item(AVFormatContext *s)
> avio_w8(pb, 0x00); // content package type
> avio_wb16(pb, 0x00); // channel handle
> avio_wb16(pb, (mxf->tc.start + frame) & 0xFFFF); // continuity count,
> supposed to overflow
> + avio_wb16(pb, mxf->last_indexed_edit_unit + mxf->edit_units_count); //
> continuity count
>
>
This looks wrong to me. Is it intended to write continuity count twice?
But I´m not an mxf expert.
Someone with more experience should have a look at this patch.
Regards,
Thomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
