2017-10-28 23:50 GMT+02:00 Clément Bœsch <u...@pkh.me>:
> On Sat, Oct 28, 2017 at 10:57:32PM +0200, Carl Eugen Hoyos wrote:
>> 2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos <ceffm...@gmail.com>:
>>
>> > Attached patch is useful in combination with the transparency patch
>> > for paletteuse.
>>
>> > +    { "background", "set a background color for transparency", 
>> > OFFSET(background), AV_OPT_TYPE_COLOR, {.str="white"}, CHAR_MIN, CHAR_MAX, 
>> > FLAGS },
>>
>> Locally changed to "lime" to make sure fate stays unchanged.
>>
>
> Please use "transparency_color" as option name (and field struct).

I liked "background";-(

> Also, the correct type in the structure is uint8_t[4]
>
> And ideally, you would also document the option in doc/filters.texi
>
> You can apply any time with these changes.

Done, thank you!

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to