Le tridi 13 brumaire, an CCXXVI, Karthick J a écrit : > +static TCPSocket *first_socket = NULL;
<snip> > + avpriv_lock_avformat(); > + socket->next = first_socket; > + first_socket = socket; > + avpriv_unlock_avformat(); I strongly oppose this: we do not want new global state. Also, I am very doubtful about the feature itself. It is public, and as such should be usable for many uses, but I do not see it useful for anything but patches 3 and 4. Furthermore, it is a break of abstraction, sockets lose their simple and clear API, they are not really closed when they are closed, etc. If you are trying to implement keepalive HTTP for HLS, then most of the code should be in http.c and hls*.c, not tcp.c. Regards, -- Nicolas George
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
