2017-11-01 19:01 GMT+01:00 Carl Eugen Hoyos <ceffm...@gmail.com>: > 2017-11-01 18:31 GMT+01:00 Hendrik Leppkes <h.lepp...@gmail.com>: >> On Wed, Nov 1, 2017 at 6:25 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >>> 2017-11-01 18:16 GMT+01:00 Hendrik Leppkes <h.lepp...@gmail.com>: >>>> On Wed, Nov 1, 2017 at 5:16 PM, Carl Eugen Hoyos <ceffm...@gmail.com> >>>> wrote: >>>>> Hi! >>>>> >>>>> Attached patch silences two gcc warnings, no sample for odd channel count >>>>> found. >>>>> >>>>> #if HAVE_BIGENDIAN >>>>> - bytestream2_get_buffer(&gb, dst16, avctx->channels * >>>>> 2); >>>>> - dst16 += avctx->channels; >>>>> + uint8_t *dst = frame->data[0]; >>>>> + bytestream2_get_buffer(&gb, frame->data[0], >>>>> avctx->channels * 2); >>>>> + dst += avctx->channels * 2; >>>>> #else >>>>> channel = avctx->channels; >>>>> do { >>>> >>>> This hunk seems fishy. dst is only ever set, never read, and this code >>>> is executed in a loop but always writes to the same position. >>> >>> I had sent the wrong version, please review this one. >> >> That still won't work, dst is declared within the loop, so its reset >> back to the start at the beginning of the frame each iteration. > > New try attached.
Ping. Thank you, Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel