2017-11-06 0:35 GMT+01:00 Aurelien Jacobs <au...@gnuage.org>:
> +static int sbc_probe(AVProbeData *p)
> +{
> + int score = 0;
> + int l = strlen(p->filename);
> + if (l > 4 && !strcmp(&p->filename[l-4], ".sbc"))
> + score = AVPROBE_SCORE_EXTENSION;
This may make sense but we don't do it for any
other demuxer and if we want it it should imo be
done for all demuxers.
> + if (p->buf[0] == SBC_SYNCWORD)
> + score++;
Am I correct that the syncword is repeated
throughout the file? If yes, the probing can
be significantly improved (and would not
depend on the suffix).
Additionally, it is a little better not to return
a positive score - not even 1 - for eight bits
conformance.
Thank you!
Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
