Le septidi 27 brumaire, an CCXXVI, Aman Gupta a écrit :
> From: Aman Gupta <a...@tmm1.net>
> ---
>  libavfilter/vf_cropdetect.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

I think the changes belong in different commits, since they both change
the behaviour of the filter in different ways.

I cannot comment on the frame_nb change.

Regarding the frame crop change, I am quite doubtful: filters currently
do not handle these fields at all, yet they are copied automatically in
many cases. I am rather against adding an isolated change like that,
unless there is a clear and obvious use case.


  Nicolas George

Attachment: signature.asc
Description: Digital signature

ffmpeg-devel mailing list

Reply via email to