On Mon, Nov 27, 2017 at 04:31:38AM +0100, Carl Eugen Hoyos wrote: > 2017-11-27 4:22 GMT+01:00 Pan Bian <bianpan2...@163.com>: > > When the call to get_bits_left() fails, the return value is not an > > negative error code. This patch explicitly assignes an error > > code to the return variable ret. > > Can't this break decoding of damaged streams that could be > decoded so far?
Dear Eugen, I see your consideration. I am not familar with the decoding logic. Sorry for that. I sent this patch because I found that some other decode functions (e.g. ff_hevc_decode_nal_vps) return error code AVERROR_INVALIDDATA if overread occurs. Thanks! Pan Bian > > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel