On 12/5/2017 9:22 AM, Gyan Doshi wrote:
> Revised patch attached.

[...]

> From bbb8013e7404360139a13b58a377a29d3ca69552 Mon Sep 17 00:00:00 2001
> From: Gyan Doshi <gyando...@gmail.com>
> Date: Tue, 5 Dec 2017 13:17:53 +0530
> Subject: [PATCH] avcodec/libx265 - Add named option to set profile
> 
> Adds call to x265_param_apply_profile after x265_param_parse.
> Added as private option since HEVC profiles other than
> Main, Main 10 and MSP in AVCodecContext are consolidated in a single
> constant.

This is inconsistent with the way libx264.c does it. It calls the profile
function before the param parsing.

> +    if (ctx->profile) {
> +        if (ctx->api->param_apply_profile(ctx->params, ctx->profile) < 0) {
> +            av_log(avctx, AV_LOG_ERROR, "Invalid or incompatible profile set 
> : %s.\n", ctx->profile);
> +            av_log(avctx, AV_LOG_INFO, "Profile must match bit depth and 
> chroma sampling of output stream.\n");

Drop the second log line.

- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to