On Fri, 29 Dec 2017 23:45:10 +0100 Nicolas George <geo...@nsup.org> wrote:
> Aman Gupta (2017-12-29): > > From: Aman Gupta <a...@tmm1.net> > > > > This fixes a segfault when streaming from an HLS playlist which uses > > crypto, by ensuring ff_http_do_new_request will never be invoked on a > > non-http URLContext. > > > > Additionally it simplifies the demuxer by removing http.h and all the > > http specific code in open_url_keepalive. > > It it awfully specific for something quite minor. And it is messing with > the public API, that requires careful design. Reusing a http connection is not minor. It's pretty straightforward too, and doesn't require being stuck forever in a bikeshed carousel. > I suggest to have ff_http_do_new_request() check that its argument is > really a HTTP context and return EINVAL or ENOSYS otherwise. Unclean and fragile. How many more bugs do you want to have with this? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
