On 2018-02-09 11:29, Carl Eugen Hoyos wrote:
2018-01-15 22:36 GMT+01:00 Tomas Härdin <tjop...@acc.umu.se>:

+    if (p->buf[4] >  EXPECTED_CODEC2_MINOR_VERSION) score -=
+    if (p->buf[5] >  AVPRIV_CODEC2_MODE_MAX)        score -=
+    if (p->buf[6] != 0)                             score -=
+    return score;

Imo, this is too complicated:
If the first 32bit are correct, return MAX/2, for 24bit, return less
This should have been AVPROBE_SCORE_EXTENSION + 1,
sorry about my mistake.

Alright. A documentation update may be in order unless already done

Please threaten to push this and push after a few days.

Don't have ssh access, but I believe Michael has offered to add me several times. I'll email him a GPG signed copy of a public SSH key when I get home

ffmpeg-devel mailing list

Reply via email to