On Mon, Jan 29, 2018 at 06:53:06PM +0530, Gyan Doshi wrote:
> On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote:
> >How did you test this patch?
> By remuxing with patched ffmpeg and then checking with ffprobe, but not
> ffplay!

muxer side changes should be tested against something else than ffmpeg in
general, if possible.
Is there no other software available that supports this ?

That said, i dont see anything wrong with the patch, its more that i dont
feel fully confident about all the PCM variants in mpeg to not miss something 

also if someone else feels this patch is ok and wants to apply this without
further tests iam 100% ok with that.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad

Attachment: signature.asc
Description: PGP signature

ffmpeg-devel mailing list

Reply via email to