On Mon, Feb 26, 2018 at 9:40 AM, Tobias Rapp <t.r...@noa-archive.com> wrote:
> Signed-off-by: Tobias Rapp <t.r...@noa-archive.com>
> ---
>  fftools/ffmpeg.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index 32caa4b..3a45f43 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -2175,10 +2175,7 @@ static int ifilter_send_frame(InputFilter *ifilter, 
> AVFrame *frame)
>
>          ret = reap_filters(1);
>          if (ret < 0 && ret != AVERROR_EOF) {
> -            char errbuf[128];
> -            av_strerror(ret, errbuf, sizeof(errbuf));
> -
> -            av_log(NULL, AV_LOG_ERROR, "Error while filtering: %s\n", 
> errbuf);
> +            av_log(NULL, AV_LOG_ERROR, "Error while filtering: %s\n", 
> av_err2str(ret));
>              return ret;
>          }
>
> @@ -4638,10 +4635,7 @@ static int transcode(void)
>
>          ret = transcode_step();
>          if (ret < 0 && ret != AVERROR_EOF) {
> -            char errbuf[128];
> -            av_strerror(ret, errbuf, sizeof(errbuf));
> -
> -            av_log(NULL, AV_LOG_ERROR, "Error while filtering: %s\n", 
> errbuf);
> +            av_log(NULL, AV_LOG_ERROR, "Error while filtering: %s\n", 
> av_err2str(ret));
>              break;
>          }
>
> --
> 2.7.4

If I recall correctly logging seems to be the use case where this
macro should be used, so this looks good to me after a quick look in
the e-mail client (and simplifies this piece of code).

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to