I've been using this patch set in my production system for the past
week. There I've been running some fairly complicated filter pipelines
generated by scripts with good results - it's working reliably (no
stalls/hangs) and has solved my memory usage issue.


On Thu, 2018-02-22 at 14:10 -0500, Calvin Walton wrote:
> This revision of the patch fixes statistics by counting the number of
> times each frame has been output, rather than trying to guess at the
> time each frame is output whether it was a duplicate or drop.
> I ended up leaving the conditional check
>     if (s->status && s->frames_count == 0) {
> at the bottom of the activate function. I think I agree that the
> condition will always be true, based on the code flow, but the if
> statement documents the condition just as well as an assert would, and
> it's not like the EOF handling is in a hot path where we'd want to
> compile out the check.
> Calvin Walton (2):
>   libavfilter/vf_fps: Rewrite using activate callback
>   libavfilter/vf_fps: Minor cleanups
>  libavfilter/vf_fps.c | 392 
> ++++++++++++++++++++++++++-------------------------
>  1 file changed, 202 insertions(+), 190 deletions(-)

Calvin Walton <>
ffmpeg-devel mailing list

Reply via email to