On Wed, 7 Mar 2018, Aurelien Jacobs wrote:

On Tue, Mar 06, 2018 at 01:02:48AM +0100, Marton Balint wrote:
Accepting 'u' suffix for a time specification is neither intuitive nor
consistent (now that we don't accept m).

The 'm' SI prefix is still accepted in various time options, and the 'u'
prefix is still accepted in those options even after your patch, so you
can't really argue that this patch improve consistency.
(eg. -black_min_duration 5ms is still accepted).
So this will surprise nobody that I don't like this patch.

This really is a cursed topic, I am not sure I follow, after the patch:

5ms is accepted
5us is accepted
5m is not accepted
5u is not accepted

You really insist on accepting '5u'? If not, then I can push the patch as is, right?

ffmpeg-devel mailing list

Reply via email to