Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: provide detail error message if parameters invalid

[Moritz Barsnick]

On Fri, Mar 02, 2018 at 11:24:10 +0800, Zhong Li wrote:
>      ret = MFXVideoENCODE_Query(q->session, &q->param, &param_out);
> -    if (ret < 0 ||
> -        param_out.mfx.RateControlMethod != q->param.mfx.RateControlMethod)

This original code gave the impression that a mismatch of
RateControlMethod was not reported by MFXVideoENCODE_Query(), and
therefore checked separately. You are not doing that anymore.

> +        if (UNMATCH(FrameInfo.FrameRateExtN) || 
> UNMATCH(FrameInfo.FrameRateExtN))

Typo? (Both macro arguments are identical.)

Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel