On 3/21/18, Nicolas George <geo...@nsup.org> wrote: > Paul B Mahol (2018-03-21): >> It is hardly identical, and I can not read your mind. > > More than half the block is identical to the previous one. > >> And it is functionally incompatible. > > I told you how you can factor it. > >> Enough bikesheds from you! > > This is a legitimate technical concern: duplicated code is bad, > duplicated that is that easy to factor is unacceptable. Enhance your > code or drop the patch, but do not apply as is.
I have legitimate technical concert about your faulty review. There is log message which is incompatible with whatever you propose. So from now on I'm pushing patches like this without review, expecially one frome you. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
