Marton Balint (2018-03-24): > Fixes parsing of expressions like c0=c0+c0. Previously no error was thrown and > only the last gain factor was used. > > Signed-off-by: Marton Balint <c...@passwd.hu> > --- > libavfilter/af_pan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for finding that misfeature. But I think your fixes goes in the wrong direction. I think that "c1=c1+c1" is much more likely to be a typo for "c1=c1+c4" than an intentional way of writing "c1=2*c1". Therefore I think it would be better to return an error, or at least print a warning, than accepting it silently. Regards, -- Nicolas George
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
