On Tue, 3 Apr 2018 09:05:18 +0300 Timo Teräs <timo.te...@iki.fi> wrote:
> Support for writing copyright metadata was added in commit bed4fc54c9 > for 3GP, MOV and iTunes metadata. 3GP and MOV cases are formally > specified. However, iTunes format does not have specification, and > it seems to have been assumed that it would use the same atom as > MOV (both being Apple formats). >[snip] Ping? It's been 2 weeks since the original mail + inquiry. And one week since this. What's the usual time for waiting feedback? Would this be soon good to go in? Timo > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 97327f739d..54f19c3a73 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -3484,7 +3484,7 @@ static int mov_write_ilst_tag(AVIOContext *pb, > MOVMuxContext *mov, } > mov_write_string_metadata(s, pb, "\251cmt", "comment" , 1); > mov_write_string_metadata(s, pb, "\251gen", "genre" , 1); > - mov_write_string_metadata(s, pb, "\251cpy", "copyright", 1); > + mov_write_string_metadata(s, pb, "cprt", "copyright", 1); > mov_write_string_metadata(s, pb, "\251grp", "grouping" , 1); > mov_write_string_metadata(s, pb, "\251lyr", "lyrics" , 1); > mov_write_string_metadata(s, pb, "desc", "description",1); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel